squito commented on a change in pull request #25299: [SPARK-27651][Core] Avoid
the network when shuffle blocks are fetched from the same host
URL: https://github.com/apache/spark/pull/25299#discussion_r319560601
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -206,6 +206,8 @@ private[spark] class BlockManager(
new BlockManager.RemoteBlockDownloadFileManager(this)
private val maxRemoteBlockToMem =
conf.get(config.MAX_REMOTE_BLOCK_SIZE_FETCH_TO_MEM)
+ private val executorIdToLocalDirsCache = new mutable.HashMap[String,
Array[String]]()
Review comment:
actually we don't want to update it when an executor goes down, as the data
is still available. (some discussion of this here:
https://github.com/apache/spark/pull/25299#discussion_r315826558)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
