advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL]
Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for
partitioned table
URL: https://github.com/apache/spark/pull/25306#discussion_r319567938
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
##########
@@ -136,10 +136,9 @@ class StatisticsSuite extends
StatisticsCollectionTestBase with TestHiveSingleto
|)""".stripMargin)
spark.sql("REFRESH TABLE t1")
- // Before SPARK-19678, sizeInBytes should be equal to dataSize.
- // After SPARK-19678, sizeInBytes should be equal to
DEFAULT_SIZE_IN_BYTES.
+ // After SPARK-28573, sizeInBytes should be equal to dataSize.
val relation1 = spark.table("t1").queryExecution.analyzed.children.head
- assert(relation1.stats.sizeInBytes ===
spark.sessionState.conf.defaultSizeInBytes)
+ assert(relation1.stats.sizeInBytes === dataSize)
Review comment:
cc @wangyum, after changes applied to HiveTableRelation, we don't modify
`tableMeta` any more.
The converted `LogicalRelation(HadoopFsRelation, xx)` from
`HiveTableRelation` will actual get size by `HadoopFsRelation.sizeInBytes`.
Do you think this is an acceptable change or we should deal with stats
differently in `DetermineTableStats`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
