brkyvz commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991370 Uh oh, can you please revert? On Sun, Sep 1, 2019, 8:44 PM Hyukjin Kwon <notificati...@github.com> wrote: > *@HyukjinKwon* commented on this pull request. > ------------------------------ > > In sql/core/src/main/scala/org/apache/spark/sql/functions.scala > <https://github.com/apache/spark/pull/25354#discussion_r319798708>: > > > @@ -3942,6 +3943,69 @@ object functions { > */ > def to_csv(e: Column): Column = to_csv(e, Map.empty[String, String].asJava) > > + // turn off style check that object names must start with a capital letter > + // scalastyle:off > + object partitioning { > > Does this has a Java corresponding test? This file should be compatible > with Java side as well. I doubt if nested object works in Java API. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/25354?email_source=notifications&email_token=ABIAE642NNEDPJVMA35RHTTQHSDZZA5CNFSM4IJGHPQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDKPHLI#pullrequestreview-282391469>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABIAE63KX52GQJWGWSFB3ODQHSDZZANCNFSM4IJGHPQA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
