xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-527123585 > The test coverage is not good enough. For example, all the test cases are just updating a single column? Try to check the test cases in the other open source databases? Hi @gatorsmile , I added more test cases for update, including multi-fields updating, nested fields updating, etc. pls review. Also checked the test cases in postgresql. There're many cases for other syntax like updating via sub-query, updating multi-fields with one assignment which is not supported current by spark sql. And updating a field with an expression, we plan to add more public expressions for datasource, after which we can support that. Will add more test cases then.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
