srowen commented on a change in pull request #25684:
[SPARK-28980][CORE][SQL][STREAMING][MLLIB] Remove most items deprecated in
Spark 2.2.0 or earlier, for Spark 3
URL: https://github.com/apache/spark/pull/25684#discussion_r321285427
##########
File path: python/pyspark/sql/tests/test_context.py
##########
@@ -66,7 +66,7 @@ def test_save_and_load_table(self):
tmpPath = tempfile.mkdtemp()
shutil.rmtree(tmpPath)
df.write.saveAsTable("savedJsonTable", "json", "append", path=tmpPath)
- actual = self.spark.createExternalTable("externalJsonTable", tmpPath,
"json")
Review comment:
IIRC this failed, because HiveContext just inherits from SQLContext.
Oh, well, this is another good point: HiveContext is deprecated in 2.0! It
should just be removed, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
