Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4050#discussion_r23555820
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -218,13 +219,14 @@ class HadoopRDD[K, V](
// Find a function that will return the FileSystem bytes read by
this thread. Do this before
// creating RecordReader, because RecordReader's constructor might
read some bytes
- val bytesReadCallback = inputMetrics.bytesReadCallback.orElse(
- split.inputSplit.value match {
- case split: FileSplit =>
-
SparkHadoopUtil.get.getFSBytesReadOnThreadCallback(split.getPath, jobConf)
- case _ => None
+ val bytesReadCallback = inputMetrics.bytesReadCallback.orElse {
+ val inputSplit = split.inputSplit.value
+ if (inputSplit.isInstanceOf[FileSplit] ||
inputSplit.isInstanceOf[CombineFileSplit]) {
--- End diff --
this is fine as is, but fyi you can do the same thing in a pattern match:
```
split.inputSplit.value match {
case _: FileSplit | _: CombineFileSplit =>
SparkHadoopUtil.get.getFSBytesReadOnThreadCallback(jobConf)
case _ => None
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
