HeartSaVioR edited a comment on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking failedStages URL: https://github.com/apache/spark/pull/25706#issuecomment-528665148 I'm also seeing inconsistency among this test suite how to verify `failedStages`. ~~Some places access it directly, while other places access it via `scheduler.failedStages`.~~ Some places convert it to Set, some other places use contains and length separately, some other places directly compare with Seq. Ideally it seems to be better to deal with this as well, but not sure we would like to deal with this here or another minor PR. EDIT: failedStages and scheduler.failedStages are different reference. My bad.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
