MaxGekk commented on issue #25707: [SPARK-28587][SQL] Explicitly cast JDBC partition string literals to timestamp/date URL: https://github.com/apache/spark/pull/25707#issuecomment-528727759 In general it looks reasonable but I have these concerns: - Currently it could work with target column type `STRING`, probably. With this PR, we require to support particular type `TIMESTAMP` by user's DBMS. I would guess this can potentially break user's apps if the remote column has different type but DMBS is able to convert values from strings. - Will it work (and how well) if target column type `TIMESTAMPTZ` (`TIMESTAMP WITH TIMEZONE`). Currently, the type is implicitly converted from `STRING` to `TIMESTAMPTZ` as you mentioned in the description but with the changes `STRING` -> `TIMESTAMP` -> `TIMESTAMPTZ`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
