Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3975#issuecomment-71523305
@Lewuathe Sounds good. Thanks for going through this discussion! Looking
at the latest updates, it looks like the 2 Impurity tests are very similar.
Would you be able to put them in one ImpuritySuite file and combine the tests
to shorten the code (e.g., by using a type parameter for the Impurity type)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
