cloud-fan commented on a change in pull request #25643: [SPARK-28939][SQL] 
Propagate SQLConf for plans executed by toRdd
URL: https://github.com/apache/spark/pull/25643#discussion_r322082273
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -115,7 +115,8 @@ object SQLConf {
    * Returns the active config object within the current scope. If there is an 
active SparkSession,
    * the proper SQLConf associated with the thread's active session is used. 
If it's called from
    * tasks in the executor side, a SQLConf will be created from job local 
properties, which are set
-   * and propagated from the driver side.
+   * and propagated from the driver side, unless a has been set in the scope 
by `withExistingConf`
 
 Review comment:
   `a has been` -> `a SQLConf has been`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to