shanyu commented on issue #25705: [SPARK-29003][CORE] Fix deadlock in startup of Spark History Server URL: https://github.com/apache/spark/pull/25705#issuecomment-530219153 > What I'm concerned about is the change would also make tests skip initializing. If the test calls `updateAndCheck()`, it misses initialization. It doesn't let existing tests be broken, but brings some unintentional side-effect. Calling updateAndCheck() without start() in FsHistoryProviderSuite is fine because start() just waits for safe mode exit and for this suite of tests it is irrelevant.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org