HeartSaVioR edited a comment on issue #25705: [SPARK-29003][CORE] Fix deadlock in startup of Spark History Server URL: https://github.com/apache/spark/pull/25705#issuecomment-530223614 > start() just waits for safe mode exit and for this suite of tests it is irrelevant. No. There're some initializations happening in `startPolling()`, and it's only called once we call `initialize()`. Even IS_TESTING is set, remaining initializations are executed. https://github.com/apache/spark/blob/7f36cd2aa5e066a807d498b8c51645b136f08a75/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L243-L284 Safe mode exit is just one of functionalities in `initialize()`. So while we might be able to say it doesn't break the existing tests so it's kind of safe, it still brings side-effect.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
