JkSelf commented on a change in pull request #25295: [SPARK-28560][SQL]
Optimize shuffle reader to local shuffle reader when smj converted to bhj in
adaptive execution
URL: https://github.com/apache/spark/pull/25295#discussion_r323554098
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ReduceNumShufflePartitions.scala
##########
@@ -180,25 +180,45 @@ case class ReduceNumShufflePartitions(conf: SQLConf)
extends Rule[SparkPlan] {
case class CoalescedShuffleReaderExec(
child: QueryStageExec,
- partitionStartIndices: Array[Int]) extends UnaryExecNode {
+ partitionStartIndices: Array[Int],
+ var isLocal: Boolean = false) extends UnaryExecNode {
override def output: Seq[Attribute] = child.output
override def doCanonicalize(): SparkPlan = child.canonicalized
override def outputPartitioning: Partitioning = {
Review comment:
@viirya
Maybe not override `requiredChildDistribution`. Because the
`requiredChildDistribution` of `CoalescedShuffleReaderExec` is
`UnspecificedDistribution` whether the `isLocal ` is `true `or `false`, the
`EnsureRequirements ` will not introduce the additional shuffle exchange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
