maropu commented on a change in pull request #25766: [SPARK-29061][SQL] Prints bytecode statistics in debugCodegen URL: https://github.com/apache/spark/pull/25766#discussion_r323710328
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ########## @@ -1353,19 +1370,17 @@ object CodeGenerator extends Logging { byteCodeSize } } - Some(stats) + (classCodeSize, methodCodeSizes.max, constPoolSize) Review comment: How about the latest code? I added a new metric (# of inner classes), so using a tuple in that part is ok? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org