maropu commented on a change in pull request #25710: [SPARK-29008][SQL] Define
an individual method for each common subexpression in HashAggregateExec
URL: https://github.com/apache/spark/pull/25710#discussion_r323718636
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -419,4 +419,27 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("Give up splitting subexpression code if a parameter length goes over
the limit") {
+ withSQLConf(
+ SQLConf.CODEGEN_SPLIT_AGGREGATE_FUNC.key -> "false",
Review comment:
Yea, we need to. If that flag is true, `HashAggregateExec` throws an
exception in this test:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala#L327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
