srowen commented on a change in pull request #25769: [SPARK-29032][CORE] Add
PrometheusServlet to monitor Master/Worker/Driver
URL: https://github.com/apache/spark/pull/25769#discussion_r323751789
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
##########
@@ -43,6 +43,12 @@ private[spark] class MetricsConfig(conf: SparkConf) extends
Logging {
prop.setProperty("*.sink.servlet.path", "/metrics/json")
prop.setProperty("master.sink.servlet.path", "/metrics/master/json")
prop.setProperty("applications.sink.servlet.path",
"/metrics/applications/json")
+
+ prop.setProperty("*.sink.prometheusServlet.class",
Review comment:
Actually one last question - does this cause prometheusServlet to always be
configured and available? I had thought this more opt-in, that it wouldn't be
on by default unless configured. Just checking whether that's true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
