cloud-fan commented on a change in pull request #25774: [SPARK-29069][SQL]
ResolveInsertInto should not do table lookup
URL: https://github.com/apache/spark/pull/25774#discussion_r323770329
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -785,41 +794,28 @@ class Analyzer(
object ResolveInsertInto extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators
{
- case i @ InsertIntoStatement(u: UnresolvedRelation, _, _, _, _) if
i.query.resolved =>
- lookupV2Relation(u.multipartIdentifier) match {
- case scala.Left((_, _, Some(v2Table: Table))) =>
- resolveV2Insert(i, v2Table)
- case scala.Right(Some(v2Table: Table)) =>
- resolveV2Insert(i, v2Table)
- case _ =>
- i
+ case i @ InsertIntoStatement(r: DataSourceV2Relation, _, _, _, _) if
i.query.resolved =>
+ // ifPartitionNotExists is append with validation, but validation is
not supported
Review comment:
just indentation changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
