cloud-fan commented on a change in pull request #25766: [SPARK-29061][SQL]
Prints bytecode statistics in debugCodegen
URL: https://github.com/apache/spark/pull/25766#discussion_r323816539
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
##########
@@ -90,4 +90,30 @@ class DebuggingSuite extends SharedSparkSession {
| id LongType: {}
|""".stripMargin))
}
+
+ test("Prints bytecode statistics in debugCodegen") {
+ Seq(("SELECT sum(v) FROM VALUES(1) t(v)", (0, 0)),
+ // We expect HashAggregate uses an inner class for fast hash maps
+ // in partial aggregates with keys.
Review comment:
I'd like to avoid end-to-end tests in this case. It's highly coupled with
how we codegen these operators and is easy to break if we change the
implementation in the future.
Can we add some UT that calls `CodeGenerator.compile` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
