GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/4225
SPARK-1934 [CORE] "this" reference escape to "selectorThread" during
construction in ConnectionManager
This change reshuffles the order of initialization in `ConnectionManager`
so that the last thing that happens is running `selectorThread`, which invokes
a method that relies on object state in `ConnectionManager`
@zsxwing also reported a similar problem in `BlockManager` in the JIRA, but
I can't find a similar pattern there. Maybe it was subsequently fixed?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-1934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4225
----
commit c4dec3b00426a1a427a4e8f88c6f733c583ebc97
Author: Sean Owen <so...@cloudera.com>
Date: 2015-01-27T17:25:26Z
Init all object state in ConnectionManager constructor before starting
thread in constructor that accesses object's state
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
