dongjoon-hyun commented on a change in pull request #25748:
[SPARK-28904][KUBERNETES] Create mount for PvTestSuire
URL: https://github.com/apache/spark/pull/25748#discussion_r323895070
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PVTestsSuite.scala
##########
@@ -42,23 +48,14 @@ private[spark] trait PVTestsSuite { k8sSuite:
KubernetesSuite =>
.withKind("PersistentVolume")
.withApiVersion("v1")
.withNewMetadata()
- .withName("test-local-pv")
+ .withName(PV_NAME)
.endMetadata()
.withNewSpec()
.withCapacity(Map("storage" -> new
QuantityBuilder().withAmount("1Gi").build()).asJava)
.withAccessModes("ReadWriteOnce")
.withPersistentVolumeReclaimPolicy("Retain")
- .withStorageClassName("test-local-storage")
- .withLocal(new LocalVolumeSourceBuilder().withPath(VM_PATH).build())
- .withNewNodeAffinity()
- .withNewRequired()
- .withNodeSelectorTerms(new NodeSelectorTermBuilder()
- .withMatchExpressions(new NodeSelectorRequirementBuilder()
- .withKey("kubernetes.io/hostname")
- .withOperator("In")
- .withValues("minikube", "docker-for-desktop",
"docker-desktop").build()).build())
Review comment:
I'm agree with you that `minikube` is the facto standard here~
If you need to remove `PVTestsSuite` like `DepsTestSuite` in this PR, please
file another JIRA issue to recover it later and add an IDed TODO to
`PVTestsSuite` class description. Otherwise, this test coverage loss will not
be recovered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
