viirya commented on issue #25717: [SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-531524227 > btw, this pr doesn't include end-to-end tests and do you think the queries in the existing tests are enough for the end-to-end tests of this pr? I'm not sure about how much the existing tests include structurally equivalent exprs though... Regarding end-to-end tests, I am not sure what test we need. If there are end-to-end tests of current sub-expresssion elimination, I think I can write tests based on that. > Also, no negative performance impacts on the existing queries, e.g., TPCDS? I have not run a TPCDS benchmark with this. Just `TPCDSQueryBenchmark` is enough?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
