Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r23652781
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -113,12 +129,12 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
"Logging directory specified is not a directory:
%s".format(logDir))
}
- checkForLogs()
+ // A task that periodically checks for event log updates on disk.
+ pool.scheduleAtFixedRate(getRunner(checkForLogs), 0,
UPDATE_INTERVAL_MS, TimeUnit.MILLISECONDS)
- // Disable the background thread during tests.
- if (!conf.contains("spark.testing")) {
--- End diff --
I don't know why this was turned off for testing, but it doesn't seem like
you want to change that behavior, do you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
