dongjinleekr commented on a change in pull request #25792:
[SPARK-23539][SS][FOLLOWUP][TESTS] Add UT to ensure existing query doesn't
break with default conf of includeHeaders
URL: https://github.com/apache/spark/pull/25792#discussion_r324499294
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
##########
@@ -1162,6 +1164,62 @@ class KafkaMicroBatchV2SourceSuite extends
KafkaMicroBatchSourceSuiteBase {
intercept[IllegalArgumentException] { test(minPartitions = "-1", 1, true) }
}
+ test("default config of includeHeader doesn't break existing query from
Spark 2.4") {
Review comment:
+1 for this test. :smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
