turboFei commented on a change in pull request #25797: [SPARK-29043][Core]
Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r324502803
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -677,10 +682,35 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
/**
* Replay the given log file, saving the application in the listing db.
*/
+
protected def mergeApplicationListing(
fileStatus: FileStatus,
scanTime: Long,
enableOptimizations: Boolean): Unit = {
+ try {
+ mergeApplicationListingHelper(fileStatus, scanTime, enableOptimizations)
+ } catch {
+ case e: InterruptedException =>
Review comment:
Hi, I have checked these expressions here and I think they are thread-safe.
- blacklist is a ConcurrentHashMap and blackList(path) is thread-safe.
- listing.delete() is thread-safe.
- endProcess is a remove operation for ConcurrentSkipListSet and it is
thread-safe.
- pendingReplayTasksCount is an AtomicInteger and it is thread-safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
