Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4151#discussion_r23656185
--- Diff: python/pyspark/ml/__init__.py ---
@@ -0,0 +1,324 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from abc import ABCMeta, abstractmethod, abstractproperty
+
+from pyspark import SparkContext
+from pyspark.sql import SchemaRDD, inherit_doc # TODO: move inherit_doc
to Spark Core
+from pyspark.ml.param import Param, Params
+from pyspark.ml.util import Identifiable
+
+__all__ = ["Pipeline", "Transformer", "Estimator", "param", "feature",
"classification"]
+
+
+def _jvm():
+ """
+ Returns the JVM view associated with SparkContext. Must be called
+ after SparkContext is initialized.
+ """
+ jvm = SparkContext._jvm
+ if jvm:
+ return jvm
+ else:
+ raise AttributeError("Cannot load _jvm from SparkContext. Is
SparkContext initialized?")
+
+
+@inherit_doc
+class PipelineStage(Params):
--- End diff --
Could we put these classes in an separated file? (such as pipeline.py)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
