Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4215#discussion_r23659468
  
    --- Diff: bin/utils.sh ---
    @@ -26,16 +26,17 @@ function gatherSparkSubmitOpts() {
         exit 1
       fi
     
    -  # NOTE: If you add or remove spark-sumbmit options,
    +  # NOTE: If you add or remove spark-submit options,
       # modify NOT ONLY this script but also SparkSubmitArgument.scala
       SUBMISSION_OPTS=()
       APPLICATION_OPTS=()
       while (($#)); do
         case "$1" in
    -      --master | --deploy-mode | --class | --name | --jars | --py-files | 
--files | \
    -      --conf | --properties-file | --driver-memory | --driver-java-options 
| \
    +      --master | --deploy-mode | --class | --name | --jars | --maven | 
--py-files | --files | \
    --- End diff --
    
    For this one maybe we could call it `--packages`. IMO maven is a little 
confusing because it's also the name of a piece of software. I'd also below 
just say `--repositories` below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to