HeartSaVioR commented on a change in pull request #25696:
[SPARK-28996][SQL][TESTS] Add tests regarding username of HiveClient
URL: https://github.com/apache/spark/pull/25696#discussion_r324956643
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -222,7 +222,7 @@ private[hive] class HiveClientImpl(
hiveConf
}
- private val userName = UserGroupInformation.getCurrentUser.getShortUserName
+ override val userName = UserGroupInformation.getCurrentUser.getShortUserName
Review comment:
I'm not 100% sure, but we have been defining userName as `val` from Spark
2.2.0, starting from this commit
https://github.com/apache/spark/commit/344f38b04b271b5f3ec2748b34db4e52d54da1bc
Changing it to def is safer anyway (can handle both cases - whether user
name is changed or not) so please let me know if we would like to make change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
