Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/4168#discussion_r23682749 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -438,6 +444,7 @@ private[spark] class ExecutorAllocationManager( } override def onTaskStart(taskStart: SparkListenerTaskStart): Unit = { + numRunningTasks += 1 --- End diff -- i think we should let numRunningTasks to synchronized,because schedule thread and listener thread are two different thread.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org