Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4249#discussion_r23696141
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
 ---
    @@ -63,6 +63,37 @@ class HiveQuerySuite extends HiveComparisonTest with 
BeforeAndAfter {
         }
       }
       
    +  test("SPARK-5324 Results of describe can't be queried") {
    --- End diff --
    
    nit: I'd prefer that the test name said what the *correct* behavior is, 
rather than the old bug it is checking for.  I think its better when we're 
looking at test output, or if there is a regression on this and a dev needs to 
figure out what is being tests.
    
    Maybe I am wrong about this, though -- we haven't applied that universally 
so far


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to