Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4155#discussion_r23699999
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -908,6 +912,11 @@ class DAGScheduler(
         val task = event.task
         val stageId = task.stageId
         val taskType = Utils.getFormattedClassName(task)
    +    val isSuccess = event.reason == Success
    +
    +    outputCommitCoordinator.taskCompleted(stageId, event.taskInfo.taskId,
    --- End diff --
    
    There should only be two spaces of indentation on the following lines.  
Also, it looks like some of the args can be pulled back up without hitting 100 
characters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to