Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4216#discussion_r23709166
--- Diff: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
---
@@ -148,15 +148,22 @@ private[deploy] object DeployMessages {
// Master to MasterWebUI
- case class MasterStateResponse(host: String, port: Int, workers:
Array[WorkerInfo],
- activeApps: Array[ApplicationInfo], completedApps:
Array[ApplicationInfo],
- activeDrivers: Array[DriverInfo], completedDrivers: Array[DriverInfo],
- status: MasterState) {
+ case class MasterStateResponse(
+ host: String,
+ port: Int,
+ stablePort: Option[Int],
+ workers: Array[WorkerInfo],
+ activeApps: Array[ApplicationInfo],
+ completedApps: Array[ApplicationInfo],
+ activeDrivers: Array[DriverInfo],
+ completedDrivers: Array[DriverInfo],
+ status: MasterState) {
Utils.checkHost(host, "Required hostname")
assert (port > 0)
def uri = "spark://" + host + ":" + port
+ def stableUri: Option[String] = stablePort.map { p => "spark://" +
host + ":" + p }
--- End diff --
I'm not sure where the right place is, but can you put in some docs or
comments on `port` vs `stablePort` & `uri` vs `stableUri`? or should
`stableXXX` be renamed to `restXXX`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
