Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4082#discussion_r23712334
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
 ---
    @@ -369,7 +369,7 @@ private[spark] class MesosSchedulerBackend(
       private def recordSlaveLost(d: SchedulerDriver, slaveId: SlaveID, 
reason: ExecutorLossReason) {
         inClassLoader() {
           logInfo("Mesos slave lost: " + slaveId.getValue)
    -      removeExecutor(slaveId.getValue)
    +      removeExecutor(slaveId.getValue, reason.toString)
    --- End diff --
    
    yes, sorry I wasn't meaning that it should hold up this PR -- I'm just 
pointing out with this alone, its far less useful than you might expect


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to