cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#discussion_r325485701
########## File path: docs/sql-keywords.md ########## @@ -280,6 +280,7 @@ Below is a list of all the keywords in Spark SQL. <tr><td>UNKNOWN</td><td>reserved</td><td>non-reserved</td><td>reserved</td></tr> <tr><td>UNLOCK</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> <tr><td>UNSET</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> + <tr><td>UPDATE</td><td>non-reserved</td><td>non-reserved</td><td>reserved</td></tr> Review comment: I checked other keywords and seems like the general rule here is to follow Postgres, we can revisit it later. cc @gengliangwang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
