Github user javadba commented on the pull request:
https://github.com/apache/spark/pull/4254#issuecomment-71929175
RE:
>> Is it possible to do Gaussian similarity in another PR? It should be
part of the feature transformation but not within PIC. It would be easier for
code review if the PR is minimal.
This is a big change late in the game. We could do the following more
easily: change the signature to PIC to allow the input to be the Affinity
Matrix (user defined). Then we retain the code for the Gaussian similarity
calculation to be sent in . Our tests and documentation and verification all
depend on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
