dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL]
Make maven central repository in IsolatedClientLoader configurable
URL: https://github.com/apache/spark/pull/25849#discussion_r326468590
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -112,18 +115,18 @@ private[hive] object IsolatedClientLoader extends
Logging {
private def downloadVersion(
version: HiveVersion,
hadoopVersion: String,
- ivyPath: Option[String]): Seq[URL] = {
+ ivyPath: Option[String],
+ centralRepo: String): Seq[URL] = {
val hiveArtifacts = version.extraDeps ++
Seq("hive-metastore", "hive-exec", "hive-common", "hive-serde")
.map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
Seq("com.google.guava:guava:14.0.1",
s"org.apache.hadoop:hadoop-client:$hadoopVersion")
-
val classpath = quietly {
SparkSubmitUtils.resolveMavenCoordinates(
hiveArtifacts.mkString(","),
SparkSubmitUtils.buildIvySettings(
- Some("http://www.datanucleus.org/downloads/maven2";),
Review comment:
@xuanyuanking . If then, could you make a separate PR for this line change?
Then, we can backport your new PR to branch-2.4, too. After that, we can
proceed this PR on top of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
