xuanyuanking commented on a change in pull request #25849: [SPARK-29175][SQL]
Make additional remote maven repository in IsolatedClientLoader configurable
URL: https://github.com/apache/spark/pull/25849#discussion_r326474439
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -112,18 +115,18 @@ private[hive] object IsolatedClientLoader extends
Logging {
private def downloadVersion(
version: HiveVersion,
hadoopVersion: String,
- ivyPath: Option[String]): Seq[URL] = {
+ ivyPath: Option[String],
+ centralRepo: String): Seq[URL] = {
val hiveArtifacts = version.extraDeps ++
Seq("hive-metastore", "hive-exec", "hive-common", "hive-serde")
.map(a => s"org.apache.hive:$a:${version.fullVersion}") ++
Seq("com.google.guava:guava:14.0.1",
s"org.apache.hadoop:hadoop-client:$hadoopVersion")
-
val classpath = quietly {
SparkSubmitUtils.resolveMavenCoordinates(
hiveArtifacts.mkString(","),
SparkSubmitUtils.buildIvySettings(
- Some("http://www.datanucleus.org/downloads/maven2";),
Review comment:
Yes, as the discussion above, the flakiness is caused by when the Jenkins
blocked by maven central repo and the additional datanucleus remote repo still
not work.
I updated this PR to set google mirror as an additional remote repo for hive
tests in 49ea1cd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
