cloud-fan commented on a change in pull request #25651: [SPARK-28948][SQL]
Support passing all Table metadata in TableProvider
URL: https://github.com/apache/spark/pull/25651#discussion_r328621570
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala
##########
@@ -31,14 +31,15 @@ import org.apache.spark.sql.types.StructType
* An implementation of catalog v2 `Table` to expose v1 table metadata.
*/
private[sql] case class V1Table(v1Table: CatalogTable) extends Table {
+ assert(v1Table.provider.isDefined)
Review comment:
Only view has no provider. So this is guaranteed. Please see the parameter
doc of `CatalogTable#provider`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
