igozali commented on issue #25910: [SPARK-28762][CORE] Read JAR main class if JAR is not located in local file system URL: https://github.com/apache/spark/pull/25910#issuecomment-535568927 Hi @srowen, thanks for taking the time to give a review. For your last comment, if I try to keep as much of the original structure, there will be a bit of superfluous code for the error being thrown, so I moved the try-catch outside the uriScheme match - I hope that's ok.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
