Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3798#discussion_r23823428
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/Leader.scala ---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.streaming.kafka
+
+import kafka.common.TopicAndPartition
+
+/** Host info for the leader of a Kafka TopicAndPartition */
+
+trait Leader {
+ /** kafka topic name */
+ def topic: String
+
+ /** kafka partition id */
+ def partition: Int
+
+ /** kafka hostname */
+ def host: String
+
+ /** kafka host's port */
+ def port: Int
+}
+
+private class LeaderImpl(
+ override val topic: String,
+ override val partition: Int,
+ override val host: String,
+ override val port: Int
+) extends Leader
+
+object Leader {
+ def create(
+ topic: String,
+ partition: Int,
+ host: String,
+ port: Int): Leader =
+ new LeaderImpl(
--- End diff --
I think this fits in 100 chars. Should be fine to put in a line. Otherwise
looks unnecessarily long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
