squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add
a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#discussion_r329843402
##########
File path: python/pyspark/ml/tests/test_wrapper.py
##########
@@ -28,6 +29,11 @@
class JavaWrapperMemoryTests(SparkSessionTestCase):
+ @unittest.skipIf(
+ os.environ.get("PYSPARK_PIN_THREAD", "false").lower() == "true",
+ "When the thread is pinned between Python and JVM, detaching seems not
"
+ "working. This is potentially a bug in Py4J and SPARK-18630 can be
persistent when "
+ "PYSPARK_PIN_THREAD is enabled, skipping for now.")
Review comment:
hmm, ok maybe take back my previous comment about thinking pinned mode is
OK. This sounds like a major problem. Long-running job-server style
deployments seem like cases where you'd want the advantage of this feature, but
also where not having proper GC would be a huge problem.
Have you had a chance to look at this anymore, or ask the py4j community
about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
