Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/3976#discussion_r23858127
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -267,10 +277,22 @@ object SparkSubmit {
// In yarn-cluster mode, use yarn.Client as a wrapper around the user
class
if (isYarnCluster) {
childMainClass = "org.apache.spark.deploy.yarn.Client"
- if (args.primaryResource != SPARK_INTERNAL) {
- childArgs += ("--jar", args.primaryResource)
+ if (args.isPython) {// yarn-cluster mode for python application
+ val primaryResourceLocalPath = new Path(args.primaryResource)
+ childArgs += ("--primaryResource",
primaryResourceLocalPath.getName)
+ val pyFilesLocalNames:String = if (args.pyFiles != null) {
+ args.pyFiles.split(",").map { p => (new Path(p)).getName
}.mkString(",")
+ } else {
+ "null"
+ }
+ childArgs += ("--py-files", pyFilesLocalNames.toString)
--- End diff --
No need for `toString`, this is already a string. Also, can we avoid
adding this arg at all instead of using "null"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
