ueshin commented on a change in pull request #25666: [SPARK-28962][SQL] Provide
index argument to filter lambda functions
URL: https://github.com/apache/spark/pull/25666#discussion_r330375481
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -369,6 +383,9 @@ case class ArrayFilter(
var i = 0
while (i < arr.numElements) {
elementVar.value.set(arr.get(i, elementVar.dataType))
+ if (indexVar.isDefined) {
Review comment:
I think this is good enough to go.
How about merging this for now, and addressing it in a separate PR?
`transform` is doing the same way, so I think we should do the same thing if
needed, maybe at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
