maropu commented on issue #26008: [MINOR][TESTS] Rename JsonBenchmark.scala to JSONBenchmark.scala to match class name URL: https://github.com/apache/spark/pull/26008#issuecomment-537800095 nit: we have no consistent name rule for that? Since `Json` is more popular, `JSONBenchmark` -> `JsonBenchmark` instead of `JsonBenchmark.scala` -> `JSONBenchmark.scala`? ``` $ find . -type f | grep -e "\.scala$" | grep Json ./core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ./core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ./core/src/test/scala/org/apache/spark/deploy/JsonProtocolSuite.scala ./core/src/test/scala/org/apache/spark/JsonTestUtils.scala ./core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala ./external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/JsonUtils.scala ./external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/JsonUtilsSuite.scala ./mllib/src/main/scala/org/apache/spark/ml/linalg/JsonMatrixConverter.scala ./mllib/src/main/scala/org/apache/spark/ml/linalg/JsonVectorConverter.scala ./mllib/src/test/scala/org/apache/spark/ml/linalg/JsonMatrixConverterSuite.scala ./mllib/src/test/scala/org/apache/spark/ml/linalg/JsonVectorConverterSuite.scala ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JsonInferSchemaSuite.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonOutputWriter.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonDataSourceV2.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonPartitionReaderFactory.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonScan.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonScanBuilder.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonTable.scala ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/json/JsonWriteBuilder.scala ./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmark.scala ./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonParsingOptionsSuite.scala ./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala ./sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala ./sql/core/src/test/scala/org/apache/spark/sql/execution/SQLJsonProtocolSuite.scala ./sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ./sql/hive/src/test/scala/org/apache/spark/sql/sources/JsonHadoopFsRelationSuite.scala $ find . -type f | grep -e "\.scala$" | grep JSON ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
