Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3233#discussion_r23860361
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -327,8 +326,14 @@ object SparkSubmit {
printStream.println("\n")
}
- val loader = new ExecutorURLClassLoader(new Array[URL](0),
- Thread.currentThread.getContextClassLoader)
+ val loader =
+ if (sysProps.getOrElse("spark.driver.userClassPathFirst",
"false").toBoolean) {
+ new ChildFirstURLClassLoader(new Array[URL](0),
--- End diff --
That kinda clashes with Sandy's comment, which I agree with, that calling
them "Executor" is misleading since they're used in other contexts. And
frankly, compared to the other changes here, changing those class names is a
very small one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
