dbtsai commented on a change in pull request #26017: [SPARK-29351][CORE] Avoid
Full Synchronization in ShuffleMapStage
URL: https://github.com/apache/spark/pull/26017#discussion_r331326456
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -113,7 +136,7 @@ private class ShuffleStatus(numPartitions: Int) {
* Removes all shuffle outputs associated with this host. Note that this
will also remove
* outputs which are served by an external shuffle server (if one exists).
*/
- def removeOutputsOnHost(host: String): Unit = {
+ def removeOutputsOnHost(host: String): Unit = withWriteLock {
Review comment:
Since it's reentrant lock, I prefer to have it in all the methods in case
someone adds something without guarding by lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
