HyukjinKwon commented on a change in pull request #25938:
[SPARK-29203][SQL][TESTS][2.4] Reduce shuffle partitions in SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/25938#discussion_r331332485
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -98,6 +100,10 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
private val inputFilePath = new File(baseResourcePath,
"inputs").getAbsolutePath
private val goldenFilePath = new File(baseResourcePath,
"results").getAbsolutePath
+ override def sparkConf: SparkConf = super.sparkConf
Review comment:
Yes, seems adding a `protected` modifier is correct, though, we don't
usually make separate PRs to address minor nits. Since the PR is open, I guess
it's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
