Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4293#discussion_r23885959
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -308,6 +309,14 @@ class HadoopRDD[K, V](
// Do nothing. Hadoop RDD should not be checkpointed.
}
+ override def persist(storageLevel: StorageLevel): this.type = {
+ if (storageLevel.deserialized) {
+ throw new SparkException("Can't cache HadoopRDDs as deserialized
objects because Hadoop's" +
--- End diff --
Are there any conceivable situations where existing code that's doing this
wouldn't have a bug?
> On Jan 30, 2015, at 6:59 PM, Reynold Xin <notificati...@github.com> wrote:
>
> In core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala:
>
> > @@ -308,6 +309,14 @@ class HadoopRDD[K, V](
> > // Do nothing. Hadoop RDD should not be checkpointed.
> > }
> >
> > + override def persist(storageLevel: StorageLevel): this.type = {
> > + if (storageLevel.deserialized) {
> > + throw new SparkException("Can't cache HadoopRDDs as deserialized
objects because Hadoop's" +
> throwing an exception is a bit extreme and will break existing code. How
about just a warning?
>
> â
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
