Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4220#issuecomment-72308691
> Maybe a more clear solution would be to modify
`Utils.getSystemProperties` to use `stringPropertyNames` to make a copy and
return just a simple Map instead?
This sounds reasonable to me; intuitively, it seems like we'd like the map
returned from `Utils.getSystemProperties` to reflect the current values of all
properties regardless of whether they're explicitly defined in the current
properties object or inherited from something further up in the override
hierarchy.
This is pretty subtle, though, so it would be good to add a comment and a
mention of the JIRA number so that future readers can understand these
subtleties and not unknowingly break things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
