Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/4299#discussion_r23892404 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -255,12 +255,17 @@ private[spark] object Utils extends Logging { * @return true if the permissions were successfully changed, false otherwise. */ def chmod700(file: File): Boolean = { - file.setReadable(false, false) && - file.setReadable(true, true) && - file.setWritable(false, false) && - file.setWritable(true, true) && - file.setExecutable(false, false) && - file.setExecutable(true, true) + if (!isWindows) { + file.setReadable(false, false) && + file.setReadable(true, true) && + file.setWritable(false, false) && + file.setWritable(true, true) && + file.setExecutable(false, false) && + file.setExecutable(true, true) + } else { + // this logic does not work for Windows --- End diff -- Doesn't this comment belong after `if (!isWindows)`, and not in the `else` clause that presumably does work for Windows?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org