viirya commented on a change in pull request #21164: [SPARK-24098][SQL]
ScriptTransformationExec should wait process exiting before output iterator
finish
URL: https://github.com/apache/spark/pull/21164#discussion_r333158224
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
##########
@@ -174,7 +173,6 @@ case class ScriptTransformationExec(
// Ideally the proc should *not* be alive at this point but
// there can be a lag between EOF being written out and
the process
// being terminated. So explicitly waiting for the process
to be done.
- proc.waitFor()
Review comment:
I do not think we should remove proc.waitFor() here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
